Scan inline XML/PDF MIME parts, not only attachment disposition #11

New issue

Closed

opened 2026-05-11 18:52:27 +02:00 by heiko · 3 comments

heiko commented

2026-05-11 18:52:27 +02:00

Owner

Problem

internal/scanner/attachment.go only processes parts where Content-Disposition is exactly attachment.

Reference: internal/scanner/attachment.go:55.

Invoice mail can contain XML/PDF parts with inline disposition or no disposition at all, especially when the part still has a filename or an invoice content type. Those messages are currently skipped.

Expected

Process MIME parts when they have a filename or an interesting content type (application/xml, text/xml, application/pdf), regardless of whether the disposition is attachment.

Suggested fix

Treat disposition as a hint rather than a hard gate, and add tests for inline/no-disposition XML and PDF parts.

## Problem `internal/scanner/attachment.go` only processes parts where `Content-Disposition` is exactly `attachment`. Reference: `internal/scanner/attachment.go:55`. Invoice mail can contain XML/PDF parts with `inline` disposition or no disposition at all, especially when the part still has a filename or an invoice content type. Those messages are currently skipped. ## Expected Process MIME parts when they have a filename or an interesting content type (`application/xml`, `text/xml`, `application/pdf`), regardless of whether the disposition is `attachment`. ## Suggested fix Treat disposition as a hint rather than a hard gate, and add tests for inline/no-disposition XML and PDF parts.

heiko commented

2026-05-11 20:38:16 +02:00

Author

Owner

Branch renamed per convention:

Old: regression/issue-11-inline-mime
New: fix/11-inline-mime-parts

The old remote branch has been deleted.

Branch renamed per convention: Old: regression/issue-11-inline-mime New: fix/11-inline-mime-parts The old remote branch has been deleted.

heiko referenced this issue from a commit

2026-05-11 20:49:01 +02:00

fix: scan inline XML/PDF MIME parts, not only attachment disposition (closes #11)

heiko commented

2026-05-11 20:52:39 +02:00

Author

Owner

Fix branch pushed: fix/11-inline-mime-parts-claude

Relaxes the Walk disposition guard to also process parts with inline or missing disposition when they have an invoice-relevant content-type or filename. Also extracts filename from Content-Type name param. Regression test passes.

Fix branch pushed: [fix/11-inline-mime-parts-claude](https://forgejo.schlittermann.de/IUS/xr-invoiced/src/branch/fix/11-inline-mime-parts-claude) Relaxes the Walk disposition guard to also process parts with inline or missing disposition when they have an invoice-relevant content-type or filename. Also extracts filename from Content-Type name param. Regression test passes.

heiko commented

2026-05-11 20:55:55 +02:00

Author

Owner

Implementation branch: fix/11-inline-mime-parts-codex

Implementation branch: [fix/11-inline-mime-parts-codex](https://forgejo.schlittermann.de/IUS/xr-invoiced/src/branch/fix/11-inline-mime-parts-codex)

heiko referenced this issue from a pull request that will close it,

2026-05-11 21:28:40 +02:00

fix: scan inline XML/PDF MIME parts, not only attachment disposition #18

heiko closed this issue

2026-05-11 22:25:58 +02:00

heiko referenced this issue from a commit