Double mailbox in warn/error log output ([INBOX] ... mailbox=INBOX) #25

New issue

Closed

opened 2026-05-12 09:34:41 +02:00 by heiko · 1 comment

heiko commented

2026-05-12 09:34:41 +02:00

Owner

Found during review of #24.

In cmd/xr-invoiced/handler.go the text and journal handlers prefix warn/error messages with [mailbox], then the unconditional attr-append loop also writes mailbox=<name> from h.attrs. Resulting line:

[INBOX] process uid uid=42 mailbox=INBOX error=...

Tests assert the prefix is present but don't notice the redundant trailing attr.

Options:

Filter mailbox out of the attr-append loop in both textHandler and journalHandler (it's already rendered as the prefix).
Or drop the prefix and rely on the attr.

Pick one and update the tests to assert the chosen form.

Refs: PR #24

Found during review of #24. In `cmd/xr-invoiced/handler.go` the text and journal handlers prefix warn/error messages with `[mailbox]`, then the unconditional attr-append loop also writes `mailbox=<name>` from `h.attrs`. Resulting line: ``` [INBOX] process uid uid=42 mailbox=INBOX error=... ``` Tests assert the prefix is present but don't notice the redundant trailing attr. Options: - Filter `mailbox` out of the attr-append loop in both `textHandler` and `journalHandler` (it's already rendered as the prefix). - Or drop the prefix and rely on the attr. Pick one and update the tests to assert the chosen form. Refs: PR #24

heiko added the

finding

label

2026-05-12 09:34:41 +02:00

heiko referenced this issue from a commit

2026-05-12 09:37:59 +02:00

Merge branch 'feature/idle-report-and-mailbox-errors' (closes #25)

heiko closed this issue

2026-05-12 09:37:59 +02:00

heiko commented

2026-05-13 14:03:45 +02:00

Author