debug:scan log key renamed from matched= to tagged= without notice #27

New issue

Open

opened 2026-05-12 09:34:44 +02:00 by heiko · 1 comment

heiko commented

2026-05-12 09:34:44 +02:00

Owner

Found during review of #24.

The new logArgs helper in internal/scanner/scanner.go emits "tagged", matched, ... for all code paths, including the debug:scan line that previously emitted "matched", matched:

Before:

s.logger.Info("debug:scan "+FormatCompact(cf), "matched", matched)

After:

s.logger.Info("debug:scan "+FormatCompact(cf), s.logArgs(matched, opts.Source)...)
// produces: tagged=<bool> scan=<source> [bold|dim]=true

Any external log-grep / alert keyed on matched= in debug output silently stops matching after this PR. Either:

keep emitting matched= for the debug line (e.g. a dedicated helper that uses the old key), or
explicitly call the rename out in the PR/changelog so downstream consumers can adapt.

Refs: PR #24

Found during review of #24. The new `logArgs` helper in `internal/scanner/scanner.go` emits `"tagged", matched, ...` for *all* code paths, including the `debug:scan` line that previously emitted `"matched", matched`: Before: ```go s.logger.Info("debug:scan "+FormatCompact(cf), "matched", matched) ``` After: ```go s.logger.Info("debug:scan "+FormatCompact(cf), s.logArgs(matched, opts.Source)...) // produces: tagged=<bool> scan=<source> [bold|dim]=true ``` Any external log-grep / alert keyed on `matched=` in debug output silently stops matching after this PR. Either: - keep emitting `matched=` for the debug line (e.g. a dedicated helper that uses the old key), or - explicitly call the rename out in the PR/changelog so downstream consumers can adapt. Refs: PR #24

heiko added the

finding

label

2026-05-12 09:34:44 +02:00

heiko commented

2026-05-13 14:03:45 +02:00

Author

Owner

Related commit: 8a33337. The log key rename to tagged is still present in the current tree and remains undocumented.

Related commit: 8a33337. The log key rename to tagged is still present in the current tree and remains undocumented.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

IUS/xr-invoiced#27

No description provided.

Rows
Columns