scanDelta swallows search errors ai:claude-sonnet-5-5 #50

New issue

Open

opened 2026-10-24 09:14:31 +02:00 by heiko · 0 comments

heiko commented

2026-10-24 09:14:31 +02:00

Owner

Priority: minor

Found by a 100 Go Mistakes review (#52/#53 error handling). Verified by reading the code.

Where: internal/app/app.go:~305-320 (SearchUIDs error branches, "search uids" / "search modseq")

Problem: A failing SearchUIDs is logged and scanDelta returns nil, so startup/reconnect proceeds as if the delta scan succeeded (state is not advanced, but the caller is not told). On an already broken connection the first IDLE fails and triggers a reconnect, which masks the original problem.

Fix: Return the wrapped error, or at least record it via activity.RecordError().

(co)authored by ai:claude-sonnet-5-5

**Priority: minor** Found by a 100 Go Mistakes review (#52/#53 error handling). Verified by reading the code. **Where:** `internal/app/app.go:~305-320` (`SearchUIDs` error branches, "search uids" / "search modseq") **Problem:** A failing `SearchUIDs` is logged and `scanDelta` returns `nil`, so startup/reconnect proceeds as if the delta scan succeeded (state is not advanced, but the caller is not told). On an already broken connection the first IDLE fails and triggers a reconnect, which masks the original problem. **Fix:** Return the wrapped error, or at least record it via `activity.RecordError()`. (co)authored by ai:claude-sonnet-5-5