resolveURL: maxRedirects guard inconsistent with apiclient/redirect.go #34

New issue

Open

opened 2026-05-04 17:08:03 +02:00 by heiko · 0 comments

heiko commented

2026-05-04 17:08:03 +02:00

Owner

Problem

resolveURL in internal/builder/clone.go uses len(via) >= 10 to cap redirects, while apiclient/redirect.go uses len(via) > maxRedirects (where maxRedirects = 10). The two are semantically equivalent but inconsistent, and resolveURL does not reuse the maxRedirects constant.

Suggested fix

Either export maxRedirects from apiclient and reference it here, or define a shared constant. At minimum, align the comparison operator so the intent is clear.

Identified by AI code review (Claude Sonnet 4.6)

## Problem `resolveURL` in `internal/builder/clone.go` uses `len(via) >= 10` to cap redirects, while `apiclient/redirect.go` uses `len(via) > maxRedirects` (where `maxRedirects = 10`). The two are semantically equivalent but inconsistent, and `resolveURL` does not reuse the `maxRedirects` constant. ## Suggested fix Either export `maxRedirects` from `apiclient` and reference it here, or define a shared constant. At minimum, align the comparison operator so the intent is clear. --- *Identified by AI code review (Claude Sonnet 4.6)*

heiko added the

Kind/Bug

label

2026-05-04 17:08:03 +02:00