IUS/xr-invoiced

Fork 0

fix: align config default path with service name xr-invoiced #21

Closed

heiko wants to merge 78 commits from fix/15-config-path-docs into master

heiko commented

2026-05-11 21:28:41 +02:00

Owner

Closes #15

Replaces /etc/xrechnung-scanner/ with /etc/xr-invoiced/ in config.go, doc/admin.md, and adds CLAUDE.md to git with the corrected path.

Closes #15 Replaces `/etc/xrechnung-scanner/` with `/etc/xr-invoiced/` in `config.go`, `doc/admin.md`, and adds `CLAUDE.md` to git with the corrected path.

heiko added 3 commits

2026-05-11 21:28:42 +02:00

test: cover config path docs alignment 51609987ba

fix: align config path documentation 5c512f4be1

test: verify config path docs match code ae60812a29

heiko commented

2026-05-11 21:43:57 +02:00

Author

Owner

Review findings (ai:codex)\n\nLow: cmd/xr-invoiced/main.go:267\nThe --config flag help still says the default includes /etc/xrechnung-scanner/config.yaml, while internal/config/config.go and doc/admin.md now use /etc/xr-invoiced/config.yaml. This leaves xr-invoiced --help advertising the old path. The new regression test also misses this because it scans config/docs/agent files but not cmd/xr-invoiced/main.go.\n\nNo other issues found in the touched implementation/docs.

heiko reviewed

2026-05-11 21:54:11 +02:00

heiko left a comment

Review: fix/15-config-path-docs

Missed reference: `cmd/xr-invoiced/main.go`

The flag usage string still reads:

configPath := flag.String("config", "", "path to config file (default: ./config.yaml or /etc/xrechnung-scanner/config.yaml)")

This is what users see with --help — arguably the most visible occurrence. Must be updated.

Regression test gap

The test checks internal/config/config.go, doc/admin.md, and CLAUDE.md, but not cmd/xr-invoiced/main.go. The test passes while the bug still exists in the help output.

CLAUDE.md

Adding it to git satisfies the regression test. Content is correct. Whether AI instruction files belong in the repo is a project policy question.

Summary

Core fix in config.go and doc/admin.md is correct. However:

cmd/xr-invoiced/main.go flag usage string still has the old path
The regression test has a blind spot for that file

— reviewed by ai:claude

## Review: fix/15-config-path-docs ### Missed reference: `cmd/xr-invoiced/main.go` The flag usage string still reads: ```go configPath := flag.String("config", "", "path to config file (default: ./config.yaml or /etc/xrechnung-scanner/config.yaml)") ``` This is what users see with `--help` — arguably the most visible occurrence. Must be updated. ### Regression test gap The test checks `internal/config/config.go`, `doc/admin.md`, and `CLAUDE.md`, but **not** `cmd/xr-invoiced/main.go`. The test passes while the bug still exists in the help output. ### CLAUDE.md Adding it to git satisfies the regression test. Content is correct. Whether AI instruction files belong in the repo is a project policy question. ### Summary Core fix in `config.go` and `doc/admin.md` is correct. However: 1. `cmd/xr-invoiced/main.go` flag usage string still has the old path 2. The regression test has a blind spot for that file — reviewed by ai:claude

heiko added 1 commit

2026-05-11 21:54:47 +02:00

fix: update --help flag usage string to /etc/xr-invoiced/ 9fd34830ab

heiko closed this pull request

2026-05-11 22:25:45 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

IUS/xr-invoiced!21

No description provided.

Rows
Columns